refactor/simplify #53

Merged

eliott merged 5 commits from refactor/simplify into chore/refactor

2026-06-04 20:37:10 +02:00

eliott commented

2026-05-30 20:44:12 +02:00

Owner

No description provided.

eliott added 5 commits

2026-05-30 20:44:13 +02:00

Harden import pipeline, encryption, and input validation 133f02bd40

From a full-codebase review:

- import: run wipe + import in a single transaction so a failed import can
  no longer destroy existing data with nothing restored; compensate orphaned
  accounts from a failed CreateNew import; make DataWipe atomic
- import: reject zip bombs before decompression (entry-count + declared and
  actual uncompressed-size caps) and lower the compressed upload cap
- import: structurally validate the cast-only export payload before any DB
  write, so malformed archives fail with 400 instead of a mid-tx 500
- import: per-route throttle on /import and /import/preview; stop echoing
  Better-Auth internals on account-creation failure
- crypto: version-tag random-IV ciphertext for unambiguous detection;
  document the deterministic-encryption leakage tradeoff
- http: ValidationPipe transform:true; expose X-Request-Id via CORS
- config: require SMTP vars in production; depth-guard the FK cause chain

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

perf(import): batch row inserts instead of one query per row 605e3b4326

Each importer looped issuing a separate tx.insert per row, so a sizable
import meant hundreds-to-thousands of sequential round-trips holding the
import transaction (and its locks) open. Every row already gets an explicit
v7() id and no importer uses .returning(), so the per-row reuse/dedup logic
is unchanged — rows are now collected and flushed via a single chunked
batchInsert(tx, table, rows) per table. Identical ids, counts and label
reuse; far fewer round-trips.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

perf(frame): skip full-shoot renumber when delete leaves it gapless a9607e3121

Deleting any frame ran two full-shoot UPDATEs to recompact numbers to 1..N,
even when removing the highest-numbered frame. Numbers are distinct positive
integers, so the shoot is already gapless 1..N exactly when COUNT == MAX.
Check that cheaply after the delete and skip the rewrite when it holds (the
common case); only a gap left mid-sequence still falls back to the existing
negate-then-renumber two-pass. End state is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

perf(export): derive counts from streamed rows, drop pre-count pass 87971715dc

planExport fired 11 COUNT(*) queries to populate meta.counts and then both
export paths re-read every row anyway. buildExport now derives counts from
the arrays it already collects; streamArchive tallies rows as they stream and
emits meta (with counts) last. Safe because the importer does a full
JSON.parse (key order irrelevant) and never reads meta.counts, so the archive
format is unchanged. Removes the now-dead countRows from PagedQuery.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

refactor(api): simplify checkRef, shoot mutations, and changelog update 1e4cbaf83d

- reference-validator: collapse the duplicated global/non-global branches in
  checkRef into a single query with a conditional column.
- shoot: route update/setPinned/setDone through one updateOwnedOrThrow helper
  instead of repeating the update-then-404 block three times.
- changelog: drop the pre-select existence check in update (TOCTOU); the
  UPDATE ... RETURNING already reports a missing row, and throwing before the
  item rewrite rolls the transaction back.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

eliott force-pushed refactor/simplify from 1e4cbaf83d to 4360096921

2026-06-04 20:37:05 +02:00

Compare

eliott merged commit 4bd6e53b63 into chore/refactor

2026-06-04 20:37:10 +02:00

eliott deleted branch refactor/simplify

2026-06-04 20:37:11 +02:00

eliott referenced this pull request from a commit

2026-06-04 20:37:12 +02:00

Merge pull request 'refactor/simplify' (#53) from refactor/simplify into chore/refactor