refactor/simplify #63

Merged

eliott merged 3 commits from refactor/simplify into chore/refactor

2026-05-31 11:08:30 +02:00

eliott commented

2026-05-30 20:45:50 +02:00

Owner

No description provided.

eliott added 2 commits

2026-05-30 20:45:51 +02:00

Fix reactive/zoneless and auth-flow issues from review ed66afa79a

- paginated-list: switchMap to drop stale-response races; advance page only
  after a successful append; surface fetch errors via an error signal
- guards: add take(1)/timeout/catchError to anonymous & auth-child guards
- error interceptor: avoid duplicate /login redirects on concurrent 401s
- auth service: time out waitForSession so login can't hang
- auth-redirect: reject /\ and control-char return URLs
- crud-base: add TCreateResult generic; ShootService now extends it
- effects: read signals before await in the leaflet maps (fix lost tracking)
- add takeUntilDestroyed to navigating subscribes; @ViewChild -> viewChild()
- shoot-form-drawer: guard form reset on visible(); readonly inputs/outputs
- account: add privacy policy and legal notice links

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

refactor(front): dedupe card menus and tidy form/changelog/list utils d8745ada5a

- Extract the identical Edit/Delete MenuItem array into entityCardMenu() and
  adopt it across the 7 entity cards plus the folder header.
- forms: replace the growing if-chain in getFieldErrors with a lookup table.
- changelog service: build the list() query with HttpParams instead of a
  hand-rolled, manually-encoded query string.
- lens-step: append + select a freshly saved lens instead of refetching the
  whole list (mirrors BaseEntitySelect.onSaved).
- paginated-list: drop the redundant `| null` from the error signal type.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

eliott added 1 commit

2026-05-31 11:08:23 +02:00

Merge branch 'chore/refactor' into refactor/simplify 2f6771dcda

eliott merged commit c45807fb26 into chore/refactor

2026-05-31 11:08:30 +02:00

eliott deleted branch refactor/simplify

2026-05-31 11:08:30 +02:00

eliott referenced this pull request from a commit

2026-05-31 11:08:32 +02:00

Merge pull request 'refactor/simplify' (#63) from refactor/simplify into chore/refactor