Split every function the Fallow new-only gate flagged (CRAP >= 30) into
helpers with cyclomatic complexity of at most 4, without changing
behaviour. Pure decisions (error-to-outcome mapping, insert and update
values, frame renumbering outcome, validation message, date revival,
unique candidate, resync edge, page splitting) move to sync-rules.ts with
unit tests; the DB steps become small private methods. The per-op
transaction and the shoot locking order are unchanged. The convergence
spec's pullAll helper is split into per-entity, per-row and tombstone
helpers.

Claude-Session: https://claude.ai/code/session_013Ew5mX388EkuWC6ytSKkdc

Merge branch 'develop' into feat/sync-support a25887cb4c

Merge pull request 'feat(sync): sync support for the native app' (#68 ) from feat/sync-support into develop f179cd9840

Reviewed-on: #68

eliott added 1 commit

2026-10-16 17:39:43 +02:00

Merge main into develop: sync support on the 1.0.0 refactors

tests / test (pull_request) Failing after 1m1s

Details

ea5326ea55

Re-applies the sync feature (feat/sync-support, 0.11.0) on top of main's
refactors and release 1.0.0:

- Schemas: a shared syncColumns() helper (updatedAt and syncedAt, both
  timestamp(3)) in db/audit-columns.ts, used by catalogAuditColumns and by
  shoot, frame, folder and frame_location; sync pull indexes on every synced
  table. Fixes the film_format sync index, which paged on updatedAt.
- Migration: the sync migration is regenerated as 0030 after main's 0028
  and 0029. It truncates updatedAt to the millisecond (as 0029 did for
  published_at) and starts syncedAt from the last known edit. Tested by
  test/int/migration-0030.int-spec.ts.
- Services: tombstones are recorded through main's ownedRow/assertOwnedRow
  helpers; ownedCrudModule imports SyncModule for the catalog services.
- Sync: the 409 texts come from common/duplicate-messages like the REST
  endpoints', film formats are unique per owner on push too, the DTOs
  follow strict mode and @nestjs/swagger's mapped types.
- OpenAPI: the four sync routes are documented with response DTOs, synced
  rows are open objects (additionalProperties) in the contract test, and
  the contract test exercises a sync cycle. syncedAt is documented on the
  catalog, folder, frame and frame-location responses.
- Tests: DELETE answers 204 and PATCH /frame-location answers the row.
- Dependencies: @better-auth/expo pinned to the better-auth version
  (1.6.12). Version 1.1.0.

eliott added the

run-ci

label

2026-10-16 17:39:58 +02:00

eliott merged commit 33c3a908c8 into main

2026-10-16 17:41:53 +02:00

eliott referenced this pull request from a commit

2026-10-16 17:41:54 +02:00

Merge pull request 'develop' (#70) from develop into main