bloc-cesi/cesizen-front
Archived
Watch
1
0
Fork
You've already forked cesizen-front
 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

/simplify pass: code-quality batch #30

Merged
eliott merged 1 commit from develop into main 2026-05-15 11:49:21 +02:00
Conversation 0 Commits 1 Files changed 46 +504 -462
eliott commented 2026-05-15 11:45:40 +02:00
Owner

Summary

Batch from a /simplify pass across the Angular app.

  • New common/constants/{routes,roles}.ts and a common/operators/with-toasts.ts RxJS operator; ~22 messageService.add sites in admin list pages and modals migrated
  • takeUntilDestroyed added to ~13 high-traffic components
  • Admin (/admin/*, 10 routes) and account (/mon-compte/*, 8 routes) converted to loadComponent
  • relaxation-activities-list reads userAccount from route data instead of router.url.includes('/mon-compte')
  • 126 WritableSignal<T> = signal(...) declarations collapsed to signal<T>(...) across 37 files
  • Rich-content modals: removed eager init that was overwritten by an effect on first tick
  • auth.ts: dropped the body-level statusCode === 200 gate in login()/refresh()

Test plan

  • pnpm exec tsc --noEmit — clean
  • pnpm build — admin chunks separated from the entry bundle
  • Smoke test the admin tree CRUD (activities / info pages / exercises) with toast feedback
  • Verify /mon-compte/mes-activites vs /activites-relaxation route-data branching

🤖 Generated with Claude Code

## Summary Batch from a /simplify pass across the Angular app. - New `common/constants/{routes,roles}.ts` and a `common/operators/with-toasts.ts` RxJS operator; ~22 `messageService.add` sites in admin list pages and modals migrated - `takeUntilDestroyed` added to ~13 high-traffic components - Admin (`/admin/*`, 10 routes) and account (`/mon-compte/*`, 8 routes) converted to `loadComponent` - `relaxation-activities-list` reads `userAccount` from route `data` instead of `router.url.includes('/mon-compte')` - 126 `WritableSignal<T> = signal(...)` declarations collapsed to `signal<T>(...)` across 37 files - Rich-content modals: removed eager init that was overwritten by an effect on first tick - `auth.ts`: dropped the body-level `statusCode === 200` gate in `login()`/`refresh()` ## Test plan - [ ] `pnpm exec tsc --noEmit` — clean - [ ] `pnpm build` — admin chunks separated from the entry bundle - [ ] Smoke test the admin tree CRUD (activities / info pages / exercises) with toast feedback - [ ] Verify `/mon-compte/mes-activites` vs `/activites-relaxation` route-data branching 🤖 Generated with [Claude Code](https://claude.com/claude-code)
- New constants modules (routes, roles) and a withToasts RxJS operator; migrated 22+ messageService.add sites in the admin list pages and modals
- takeUntilDestroyed added to ~13 high-traffic components (admin list pages, modals, auth flows, tracker)
- Admin (/admin/*) and account (/mon-compte/*) routes converted to loadComponent so anonymous visitors don't ship the admin tree
- relaxation-activities-list reads userAccount from route data instead of URL substring matching
- 126 WritableSignal<T> declarations collapsed to signal<T>(...) across 37 files; unused imports cleaned
- Rich-content modals: removed eager-init that was overwritten by an effect on first tick
- auth.ts: dropped the body-level statusCode === 200 gate (HTTP layer already gated entry into tap)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
eliott merged commit d3142724cb into main 2026-05-15 11:49:21 +02:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
bloc-cesi/cesizen-front!30
No description provided.