cda-solutions/resources-relationnelles-website

Archived

Watch

Fork 0

develop #9

Merged

eliott merged 41 commits from develop into main

2026-05-12 20:38:21 +02:00

eliott commented

2026-05-12 20:38:12 +02:00

Owner

No description provided.

eliott added 40 commits

2026-05-12 20:38:12 +02:00

Feat : Initialize DSFR design system 015ca45820

Wire @codegouvfr/react-dsfr into the Next.js App Router so the project
inherits the official design system out of the box. Adds the standard
dsfr-bootstrap scaffold (DsfrProvider, DsfrHead, getHtmlAttributes,
default color scheme = system), the Republique Francaise header with
service title "Ressources Relationnelles", a DSFR footer with the
theme switcher, and replaces the create-next-app starter page with a
minimal DSFR-styled home. Drops the Geist fonts in favor of Marianne
preloaded by DsfrHead. Adds predev/prebuild scripts running
react-dsfr update-icons. next.config.ts keeps output: standalone for
the Docker image.

Note: deps installed via pnpm; package-lock.json must be regenerated
on a host with npm before the Docker build (npm ci) will work again.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Merge pull request 'Feat : Initialize DSFR design system' (#5 ) from feat/dsfr-init into develop 4a0d1fad05

Reviewed-on: #5

Init website and finished it 54bc45d3a1

Merge pull request 'Init website and finished it' (#6 ) from feat/mvp-frontend into develop 3d08f619f8

Reviewed-on: #6

fix(resources): reject non-http(s) schemes in mediaUrl 3f875b6553

Add a Zod .refine() guard to the mediaUrl field in resourceFormSchema so that
javascript:, data:, vbscript:, and other non-http(s) schemes are rejected at
form-submission time with a clear French error message.

Add a defence-in-depth ALLOWED_PROTOCOLS check in classify() (ResourceMedia.tsx)
so that URLs already stored in the database with a forbidden scheme are silently
dropped (component returns null) rather than rendered as a clickable <a href>.

refactor(resources): drop unreachable try/catch in mediaUrl refine 40b018ea44

new URL() inside the refine cannot throw because z.string().url() runs first
and rejects malformed URLs. The catch branch was dead code that suggested a
failure path that does not exist.

fix(auth): enforce Secure cookie flag in prod + document JWT trust model 1522a638c2

- forwardAuthCookies: force secure:true in production regardless of what
  the upstream Set-Cookie header advertised; preserve upstream value in dev
  so local HTTP flows still work.
- clearAuthCookies: align secure flag with production environment so the
  browser honours the clearance when the live cookie was set with Secure.
- jwt.ts / session.ts: add load-bearing comments explaining that the JWT
  payload is base64-decoded only (no signature verification), that the
  .NET API is the real authorization gate, and that hasPermission() /
  permission checks are cosmetic UI gating — every Server Action must
  independently re-check authz before forwarding to the API.

refactor(auth): unify Secure cookie derivation as prod-OR-upstream 56885ea592

Aligns forwardAuthCookies with clearAuthCookies on the production check and
collapses the ternary into a single OR expression. Same semantics: Secure in
prod regardless, plus honour upstream Secure attribute in dev.

fix(resources): validate existingDocumentId GUID in upsert action d7a2a66be3

Add existingDocumentId to resourceFormSchema as an optional union of
empty string or a permissive GUID regex, matching the same pattern used
by guidSchema. Malformed values are now rejected with a field error
("Identifiant de document invalide.") before the payload reaches the API.

fix(resources): forward parsed existingDocumentId instead of re-reading FormData 530bd0887a

resolveDocumentId previously re-read existingDocumentId straight from
FormData after schema validation, sidestepping the GUID guard. Pass the
validated parsed.data.existingDocumentId through so the value that reaches
the API is always the one Zod approved.

refactor(resources): reuse guidSchema and simplify documentId coalesce 3543131f8c

refactor(api): remove dead cache directives; commit to no-store eb5dec3166

Every apiFetch call forwards user cookies, so responses must not be
cached across users. The cache: "no-store" default already prevented
next: { tags, revalidate } from having any effect, and updateTag(...)
calls had nothing to invalidate. Remove all dead next:/updateTag
plumbing and add a comment to apiFetch documenting the no-store intent.

refactor(comments): drop unused resourceId from deleteCommentAction 57e852b27f

refactor(comments): drop unused resourceId from updateCommentAction 1ddf7c0204

fix(ui): refresh server data after admin/resource mutations d1dc8d7229

Add router.refresh() after each successful mutation in TaxonomyManager,
AdminUserRow, PendingResourceRow, and MyResourceRow so parent Server
Components re-fetch and the page reflects the new state without a manual
reload.

fix(ui): refresh server data after submitDraftAction in MyResourceRow 5502fceb1c

The status tag and the visibility of the Soumettre button both depend on
resource.awaitingValidation, which only flips on the server. Without a
refresh, a successful submit leaves the card stale until the user reloads.

fix(ui): refresh server data after CommentForm + UserActionResourceCard mutations ea3a7abfac

Same staleness pattern as the four admin/my-resources rows: the comment list
above CommentForm and the bucket pages around UserActionResourceCard would
otherwise show the pre-mutation snapshot until the user manually reloaded.

fix(catalog): cap getAll fetch to prevent memory cliff; TODO server-side filters 32338568ea

The GET /resources API endpoint only accepts PaginationParams (Page/ItemsCount/GetAll)
and provides no server-side filtering, search, or sorting. Replace the unbounded
getAll:true fetch with a MAX_CATALOG_ITEMS=500 cap and add a TODO documenting
the API gap so the fix is visible when server-side filtering is eventually added.

chore: batch minor cleanups (dead routes, middleware boundary, env hoist, jwt decode dedup) fdd673e07b

- Remove dead /api/users/logout route handler and its SKIP_REFRESH_PREFIXES entry
- Tighten middleware prefix check to match exact path or prefix+"/" boundary
- Hoist API_BASE_URL into lib/api/env.ts; update four call sites (next.config, middleware, lib/api/client, lib/auth/api)
- Remove redundant `dynamic = "force-dynamic"` from reset-password and verify-email pages (apiFetch is no-store)
- Inline trivial gateTaxonomyMutation helper in lib/admin/actions.ts
- Factor duplicated base64url decode into lib/auth/jwt-edge.ts (atob-based, edge-safe); import from middleware and jwt.ts

fix(middleware): normalize /api/password prefix without trailing slash 461aa0a251

The new boundary check (prefix + '/') turned '/api/password/' into the
unmatchable '/api/password//'. Drop the trailing slash so the existing logic
covers /api/password/reset and similar correctly.

feat(resource-detail): toggle favorite/sideline/complete based on state 5b6c558406

Fetch per-resource user state server-side in the detail page (3 parallel
calls to mine/favorites, mine/sidelined, mine/completed with getAll=true)
and pass the flags to ResourceActionsBar as props. The bar now shows
"Retirer des favoris / de côté / non terminée" with primary styling when
active, calls the un-actions on click, and uses optimistic local state
with router.refresh() for post-action sync.

refactor(resource-actions-bar): block concurrent clicks, sync state after refresh a99381ad66

Three small followups to the toggle change:
- disable all three buttons while any action is pending (was: only active one)
- sync local optimistic state to props via effect, so router.refresh() landings
  reflect server truth without diverging
- annotate findResourceUserState with a TODO pointing to the API-side fix

fix(resource-actions-bar): switch to useOptimistic for state sync b9f8880038

set-state-in-effect lint rule rejects the prop->state sync I added.
useOptimistic is the React 19 native primitive for this exact case:
optimistic flip during the transition, automatic resync from the
authoritative prop when the transition ends and the parent RSC refreshes.

chore: remove pnpm-lock.yaml (npm is canonical per CLAUDE.md) 5916db3e9f

Both lockfiles were committed but the Dockerfile uses npm ci. Deleting the
pnpm lockfile eliminates drift risk.

fix: post-sweep integration gaps ff4c38edb7

- CommentItem.onDelete now calls router.refresh() so the comment thread
  reflects the deletion immediately (was relying on the now-removed
  updateTag in deleteCommentAction).
- ResourceActionsBar restores severity:'info' for the 'Action déjà
  effectuée.' 409 case instead of treating it as an error.
- .env.example documents the production-HTTPS requirement introduced
  when Secure was hardcoded for NODE_ENV=production.

feat(editor): add @tiptap/extension-image dependency df73d98736

feat(editor): shared inline-image MIME and size constants 14d257907a

feat(editor): server action for inline image upload 3627e56e44

feat(sanitizer): allow inline <img> from /api/documents only ebe05e4099

feat(editor): image toolbar button with upload and alt-text editing 51043197dc

style(editor): cap inline image width in editor and rendered content 91e25e4c8f

fix(editor): show error toast when image upload action throws 412cf88b7e

fix(server-actions): raise body size limit to 10mb for image uploads a268ceca24

refactor: simplify frontend across perf, dedup, and bug fixes 6a05ec5c83

Performance:
- Cache getSession() with React cache() so layout/header/page/action
  callers share one JWT decode per request
- Forward only access_token + refresh_token to the API instead of the
  full cookie jar; share buildAuthCookieHeader between apiFetch and
  apiFetchRaw
- Parallelise independent fetches in /ressources/[id] and the resource
  edit page
- Tag-cache taxonomy queries with updateTag("taxonomy") in admin
  mutations
- Lower MAX_CATALOG_ITEMS from 500 to 120 and add a truncation banner
- Tighten middleware matcher to skip static images and /api/* proxy

Bug fixes:
- AdminUserRow: stop mirroring userRoleIds into useState (which froze
  the display after router.refresh) — use a draft pattern instead
- Use /connexion?changed=email|password after email/password updates so
  the success copy reflects what actually changed (was reusing the
  registration banner)

Deduplication:
- passwordSchema + PASSWORD_RULES_HINT shared between auth and account
- One labeledTaxonomyDtoSchema factory for category, resource type, and
  relation type DTOs
- Move ACCEPTED_DOCUMENT_TYPES to a server-neutral constants module so
  forms can reuse it
- Centralise date formatters in lib/ui/formatters.ts (6 call sites)
- Collapse 6 resource bucket actions into setResourceBucketAction(id,
  bucket, on)
- requirePermission(mask) helper replaces 8 hand-rolled UI authz checks
  in admin actions
- useFlash hook with cleanup-on-unmount replaces 3 ad-hoc setTimeout
  toasters
- buildQuery URL helper replaces duplicated URLSearchParams logic in
  Pagination and CatalogToolbar
- applySort -> comparator lookup; verify-email cascade -> view table

Cleanup:
- Delete dead code: CategoryFilter, updateCommentAction, throwIfError,
  PermissionMask type
- Strip narrative comments that explained WHAT instead of WHY

feat(editor): remove inline image attachments from WYSIWYG f99e0dbb5d

Drops the @tiptap/extension-image dependency, the image toolbar button
and file upload handler in RichTextEditor, the uploadInlineImageAction
server action and its shared inline-image constants, and the <img> tag
allow-list in sanitize-html. The Document attachment field on the
resource form is unaffected — only inline images embedded inside rich
text are gone.

Run `npm uninstall @tiptap/extension-image` to sync package-lock.json.

Merge branch 'develop' into feat/mvp-frontend 8bbb8ba348

Merge pull request 'feat/mvp-frontend' (#7 ) from feat/mvp-frontend into develop 7c87ede1e5

Reviewed-on: #7

feat(resource-media): inline image/PDF previews; degrade unplayable video to link 16a964f783

DocumentDownload now renders an <img> for image MIME types and a sized
<iframe> for PDFs above the existing download row, both served through
the /api/documents/:id rewrite. The video branch of ResourceMedia
delegates to a new client VideoPreview component that swaps the <video>
for a plain DSFR external link when onError fires, so an unplayable
source no longer leaves an empty player placeholder on the page.

Merge branch 'develop' into feat/mvp-frontend 3c9f122815

Merge pull request 'feat(resource-media): inline image/PDF previews; degrade unplayable video to link' (#8 ) from feat/mvp-frontend into develop 25d9cc9e3b