develop #64

Merged

eliott merged 19 commits from develop into main 2026-06-04 22:20:07 +02:00

Conversation 0 Commits 19 Files changed 499 +11331 -8381

eliott commented 2026-06-04 22:18:46 +02:00

Owner

• Copy link

No description provided.

eliott added 19 commits 2026-06-04 22:18:46 +02:00

feat(signup): require privacy + legal acknowledgement at sign-up (#59) ... 0880c8e064

Reviewed-on: #59
Co-authored-by: Eliott BIDAULT-HERVOUET <homelab@eliottbidault.fr>
Co-committed-by: Eliott BIDAULT-HERVOUET <homelab@eliottbidault.fr>

Merge branch 'main' into develop ... c150836e7e

# Conflicts:
#	package.json

Fix reactive/zoneless and auth-flow issues from review ... ed66afa79a

- paginated-list: switchMap to drop stale-response races; advance page only
  after a successful append; surface fetch errors via an error signal
- guards: add take(1)/timeout/catchError to anonymous & auth-child guards
- error interceptor: avoid duplicate /login redirects on concurrent 401s
- auth service: time out waitForSession so login can't hang
- auth-redirect: reject /\ and control-char return URLs
- crud-base: add TCreateResult generic; ShootService now extends it
- effects: read signals before await in the leaflet maps (fix lost tracking)
- add takeUntilDestroyed to navigating subscribes; @ViewChild -> viewChild()
- shoot-form-drawer: guard form reset on visible(); readonly inputs/outputs
- account: add privacy policy and legal notice links

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

refactor(front): dedupe card menus and tidy form/changelog/list utils ... d8745ada5a

- Extract the identical Edit/Delete MenuItem array into entityCardMenu() and
  adopt it across the 7 entity cards plus the folder header.
- forms: replace the growing if-chain in getFieldErrors with a lookup table.
- changelog service: build the list() query with HttpParams instead of a
  hand-rolled, manually-encoded query string.
- lens-step: append + select a freshly saved lens instead of refetching the
  whole list (mirrors BaseEntitySelect.onSaved).
- paginated-list: drop the redundant `| null` from the error signal type.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

chore: relicense under AGPL-3.0-or-later ... 67b009ccb7

Add the AGPL-3.0 license text and declare the license in package.json.

chore(deps): bump Angular and tooling dependencies ... 8c8c430af2

Bump Angular and angular-eslint to 21.2.x/21.4.x, better-auth, primeng,
and dev tooling (eslint, playwright, vitest, jsdom, typescript-eslint)
with the matching pnpm-lock.yaml update.

feat(sidebar): add source-link to the sidebar nav ... adb9ad952b

Introduce the SourceLink UI component and render it alongside the theme
toggle in both the authenticated and pending sidebar states.

Replace LICENSE with verbatim FSF AGPL-3.0 text 0c017af957

Merge branch 'chore/refactor' into refactor/simplify 2f6771dcda

Merge pull request 'refactor/simplify' (#63) from refactor/simplify into chore/refactor ... c45807fb26

Reviewed-on: #63

refactor: adopt code-style.md conventions across the codebase ... 3db3e759a2

Extract inlined cards/rows into dedicated components, document the
conventions in code-style.md, and point CLAUDE.md at it.

chore: move to 0.x versioning (7.2.2 -> 0.7.2) de486daba6

ci: gate the test workflow behind a manual run-ci label 693790e863

ci: drop label-name guard (skipped jobs report success, bypassing the gate) 6f2da8dac5

refactor: settings nav rows as p-button, namespace host variant classes ... 24ddcfcb62

- settings-nav-row now wraps a PrimeNG text button instead of a hand-styled
  anchor; drop the per-tab hint line and slim the row styles accordingly
- rename nav-links / account-row host marker classes to variant-* so they
  can't collide with the parent sidebar's .sidebar layout rule, with a
  regression test on sidebar-nav
- minor _settings-list-tab cleanup

refactor: fix fallow audit gate (complexity, duplication, dead deps) ... ce813ff7f6

- add .fallowrc.jsonc: skip *.spec.ts in duplication analysis, ignore
  import-block clones, whitelist @angular/animations (loaded dynamically
  by provideAnimationsAsync, invisible to static analysis)
- split the 200-line account.html (CRAP 106.4) into six dedicated
  section components: hero, profile, security, data, about, danger
- extract shared session-gate pipeline for authGuard / authChildGuard
- extract MapHandle + switchTileLayer/teardownMap helpers shared by
  frame-map and location-picker-dialog
- extract RingControl CVA base class shared by aperture-ring and
  shutter-speed-ring
- drop dead devDependencies: @angular-eslint/* (superseded by the
  angular-eslint meta package) and schematics-scss-migrate

ci: pin fallow to 2.88.3 and disable its analysis cache ... cf64a7d1ec

Run #41 failed the new-only gate on a finding that local reproduction
at the same SHA, base and fallow version proves is inherited, not
introduced. The action's cache step had restored a .fallow/ directory
written by an older fallow release (prefix fallback key), corrupting
the introduced/inherited attribution. Pinning the CLI version and
forcing --no-cache makes the audit verdict deterministic.

refactor(shoots): extract refId helper to flatten the form-sync effect ... 098e0ac8ea

The constructor effect repeated 'x?.id ?? null' five times, putting the
arrow at cyclomatic 14 / CRAP 56.3. This was the one introduced finding
failing the fallow audit gate (line-scoped diff counts pre-existing
complexity as introduced when the PR touches lines inside it). The
helper brings the effect to cyclomatic 4.

Merge pull request 'chore/refactor' (#62) from chore/refactor into develop ... dbd7bf03a2

Reviewed-on: #62

eliott merged commit a329f57f9a into main 2026-06-04 22:20:07 +02:00

eliott referenced this pull request from a commit 2026-06-04 22:20:07 +02:00

Merge pull request 'develop' (#64) from develop into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

run-ci

Trigger the required CI run

No labels

run-ci

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

RollNote/rollnote-front!64

No description provided.